]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
networkAgent: Handle 'vpn' connections when delaying request
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 16 Dec 2019 23:21:46 +0000 (00:21 +0100)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 9 Jan 2020 01:26:01 +0000 (01:26 +0000)
Since commit 90a08ba0b6a, we only open a network secret dialog immediately
in response to user action, and show a notification otherwise.

While for the actual request VPNs are handled separately from other connections,
this isn't true when we show the notification - we need to handle 'vpn' together
with the other types there, or we fall through to the default 'invalid type'
exception.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2008

js/ui/components/networkAgent.js

index ee376326bff034841822f31dedd75487b0d2ac68..6779b314738bb776fd3555a441ccf8e407d873a6 100644 (file)
@@ -725,6 +725,10 @@ var NetworkAgent = class {
             title = _("Mobile broadband network password");
             body = _("A password is required to connect to “%s”.").format(connectionSetting.get_id());
             break;
+        case 'vpn':
+            title = _("VPN password");
+            body = _("A password is required to connect to “%s”.").format(connectionSetting.get_id());
+            break;
         default:
             log(`Invalid connection type: ${connectionType}`);
             this._native.respond(requestId, Shell.NetworkAgentResponse.INTERNAL_ERROR);